Move all utility classes into a separate module #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notjuanortiz
changed the title
|
Hey @notjuanortiz, TravisBuddy Request Identifier: f9447170-2056-11ea-8d2e-279a4df7ebeb |
notjuanortiz
changed the title
jhg023
reviewed
Dec 28, 2019
Comment on lines
-9
to
-14
| import java.util.concurrent.Executor; | ||
| import java.util.concurrent.LinkedBlockingQueue; | ||
| import java.util.concurrent.ThreadFactory; | ||
| import java.util.concurrent.ThreadPoolExecutor; | ||
| import java.util.concurrent.*; | ||
| import java.util.concurrent.ThreadPoolExecutor.CallerRunsPolicy; | ||
| import java.util.concurrent.TimeUnit; |
There was a problem hiding this comment.
Are we prohibiting wildcard imports?
notjuanortiz
changed the title
|
After putting more thought into it, the entire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts a majority of the utility classes into a separate module. I've made changes to the existing API to avoid package conflicts between the parent module and the newly introduced
utilmodule.The
utilmodule consists of the following package structureThe remaining utility classes in the parent module will not, and should, be included into the new module since they are tightly coupled to the module they are currently in. In doing so, we're also able to create and maintain a unidirectional dependency tree.