-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metatable): meta-fields are fetched using rawget #198
Conversation
Pull Request Test Coverage Report for Build 11692525966Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c.f. My question on the Penlight iteration ... I seem to recall maybe LuaJIT or some other VM I was using actually behaved differently here. All I remember clearly is I had trouble with determining this in a test suite across different VMs.
Please use the |
should we move those actions under lunarmodules? seprate topic though. Can we merge this one? |
If I wanted that, that's where I would have moved them to. :) They're designed to work with each other and ultimately serve the deployment of LuaRocks, so I consider them now part of the LuaRocks project. I'm not saying they are the authoritative Github Action to install Lua or anything (Leaf's original Action still exists, after all). But as far as I'm concerned, I'm only worried about keeping those lua and luarocks actions working in tandem for the benefit of LuaRocks-based projects, so that's where I moved my personal fork. For people with other needs, they are of course free to make their own fork. |
I think the luarocks org makes sense for those actions—more so than lunarmodules. The only thing I'd consider is perhaps adding a few more hands to them. Is fr as I know Leaf is fine and just otherwise occupied at the moment, but the biggest problem with those otherwise great actions was the bus factor where upstream moved the cheese and they were not around to get them patched up. As to this PR.... Yes I think we're good here. There isn't much other major reason to get out a patch release, but with this in we could probably go for one. Should I get that together? |
No description provided.