Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metatable): meta-fields are fetched using rawget #198

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Nov 5, 2024

No description provided.

@coveralls
Copy link

coveralls commented Nov 5, 2024

Pull Request Test Coverage Report for Build 11692525966

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 10994407327: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Copy link
Member

@alerque alerque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c.f. My question on the Penlight iteration ... I seem to recall maybe LuaJIT or some other VM I was using actually behaved differently here. All I remember clearly is I had trouble with determining this in a test suite across different VMs.

@alerque
Copy link
Member

alerque commented Nov 6, 2024

The LuaJIT test is broken because @leafo's Action for it has been broken for some time. There is an active PR to fix it, but it has been quite a while now. I've had to more a few projects to @hishamhm's fork. We should probably do that on this project since testing it actually matters here.

@hishamhm
Copy link
Member

hishamhm commented Nov 6, 2024

I've had to more a few projects to @hishamhm's fork.

Please use the luarocks org URL -- I've moved my personal fork to that org.

@Tieske
Copy link
Member Author

Tieske commented Nov 7, 2024

should we move those actions under lunarmodules?

seprate topic though. Can we merge this one?

@hishamhm
Copy link
Member

hishamhm commented Nov 7, 2024

should we move those actions under lunarmodules?

If I wanted that, that's where I would have moved them to. :) They're designed to work with each other and ultimately serve the deployment of LuaRocks, so I consider them now part of the LuaRocks project. I'm not saying they are the authoritative Github Action to install Lua or anything (Leaf's original Action still exists, after all). But as far as I'm concerned, I'm only worried about keeping those lua and luarocks actions working in tandem for the benefit of LuaRocks-based projects, so that's where I moved my personal fork. For people with other needs, they are of course free to make their own fork.

@alerque
Copy link
Member

alerque commented Nov 7, 2024

I think the luarocks org makes sense for those actions—more so than lunarmodules. The only thing I'd consider is perhaps adding a few more hands to them. Is fr as I know Leaf is fine and just otherwise occupied at the moment, but the biggest problem with those otherwise great actions was the bus factor where upstream moved the cheese and they were not around to get them patched up.

As to this PR....

Yes I think we're good here. There isn't much other major reason to get out a patch release, but with this in we could probably go for one. Should I get that together?

@alerque alerque merged commit 2be28cb into master Nov 7, 2024
13 of 15 checks passed
@alerque alerque deleted the metatables branch November 7, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants