Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup snowflake tables after test suite #426

Open
machow opened this issue Jun 9, 2022 · 0 comments
Open

Cleanup snowflake tables after test suite #426

machow opened this issue Jun 9, 2022 · 0 comments

Comments

@machow
Copy link
Owner

machow commented Jun 9, 2022

Currently, our snowflake tests generate unique tables (so the test suite can be run multiple times concurrently). However, unlike other backends, we don't clean up the tables. See this code:

https://github.com/machow/siuba/blob/main/siuba/tests/helpers.py#L177-L193

The problem is that for other backends like postgres, we simply teardown containers. For bigquery, we make tables that delete after a day. However, I don't think there are similar moves with snowflake.

We should probably just do the following:

  • have the backend track tables added
  • have its fixture call a teardown_tables() method, to delete them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant