You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working on those LOL drivers, I noticed a few things:
several documentation files state that the VersionInfo strings come from the PE header, that is incorrect, as they come from a string table in the resources section
the yara-generator.py uses utf-16be instead of utf-16le to generate the hex encoded strings. This works because there usually is a zero byte before the string from the previous one, but should be fixed
a few rules only contain a FileVersion or ProductVersion from that string table. These might be too broad and could result in FPs
I can submit a PR for the first two points if desired, for the third point I guess it's up to you, but at least a sentence about it would be helpful.
The text was updated successfully, but these errors were encountered:
Hey @arty-hlr a PR for the firs two would be awesome thank you! As per the FileVersion or ProductVersion, are you referring to yara rules mind pointing me to it. Likely I can adjust the generation script to make it more specific.
Hello,
While working on those LOL drivers, I noticed a few things:
I can submit a PR for the first two points if desired, for the third point I guess it's up to you, but at least a sentence about it would be helpful.
The text was updated successfully, but these errors were encountered: