Fix small eviction bug; add the ability to track evictions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frobcode
force-pushed
the
fix_eviction_bug_and_track_evictions
branch
from
a50ebb6 to
726b4b8
Compare
nicktimko
pushed a commit
to nicktimko/expiringdict
that referenced
this pull request
Jan 21, 2020
Minimal version of PR mailgun#32 without adding a counter.
horkhe
added a commit
that referenced
this pull request
Jan 27, 2020
Fix bug when setting existing key in full dict (minimal version of PR #32)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I wanted to be able to track evictions, and found a fun little bug in the eviction code (if you update an existing value, it will delete the oldest value in the dict).
Thanks for this handy class!