Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise-based write API? #124

Open
charlieforward9 opened this issue May 23, 2024 · 0 comments
Open

Promise-based write API? #124

charlieforward9 opened this issue May 23, 2024 · 0 comments

Comments

@charlieforward9
Copy link
Contributor

charlieforward9 commented May 23, 2024

shp-write/src/write.js

Lines 15 to 16 in 48a0fe7

// Low-level writing interface
function write(rows, geometry_type, geometries, callback) {

While updating the README, I realized that write does not use async/await. This seems ancient. This issue tracks the upgrade of this (unless the current callback form is in fact better for some reason)

@charlieforward9 charlieforward9 changed the title Promise-based API? Promise-based write API? May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant