Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'request' #1006

Closed
acalcutt opened this issue Oct 6, 2023 · 2 comments · Fixed by #1043
Closed

Replace 'request' #1006

acalcutt opened this issue Oct 6, 2023 · 2 comments · Fixed by #1043

Comments

@acalcutt
Copy link
Collaborator

acalcutt commented Oct 6, 2023

The request package used by tileserver-gl has been depreciated for quite a while and now has some vunerabilities. I think we should make some effort to replace it with something newer. I have looked a bit in the past and there are some options to replace it, but I have gotten stuck on understating the gzip features tileserver-gl uses.

If anyone has any ideas to replace it I would love to see a PR. I think it only gets used in https://github.com/maptiler/tileserver-gl/blob/master/src/serve_rendered.js

@mjj203
Copy link

mjj203 commented Oct 18, 2023

I issued a pull request to your fork of tileserver-gl. Actually had to update main.js and serve_rendered.js with axios. acalcutt#284

@acalcutt
Copy link
Collaborator Author

Thanks, I looked at it and it looks good. Would you be able to make a PR on the maptiler/tileserver-gl master branch instead of my old fork? I have been putting in my effort here, so my fork is a bit out of date now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants