-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An option for multiple Configuration #54
Comments
Hi, sounds like a very good idea. This could be an easy, but breaking change for the build monitor configuration. I'll think about, how to implement this. |
I've made a quick implementation in the feature branch multi-configuration. There are still several things to do (client settings, refactoring, concept for naming the groups, ...). Maybe you can take a look at it and tell me, if it is working in the way you imagined. |
That was really fast :) . Will spend sometime between today and saturday
to check out this branch. Really appreciate your help :) . I am hoping
that I can contribute to this efforts as well by doing my bit.
Best regards,
Karthik Krishnan.
http://karthiks.in
…On Wed, Jul 26, 2017 at 7:05 PM, Marcell Spies ***@***.***> wrote:
I've made a quick implementation in the feature branch multi-configuration
<https://github.com/marcells/node-build-monitor/tree/feature/multi-configuration>.
There are still several things to do (client settings, refactoring, concept
for naming the groups, ...). Maybe you can take a look at it and tell me,
if it is working in the way you imagined.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXe6qAT6ehrciahPhjuB6Ec4jHLgh46ks5sR8Y_gaJpZM4Ohg5E>
.
|
Thank you. Maybe you can give me some input. I'd like to implement an easy solution first. If possible, without breaking changes for existing solutions. |
Hi Marcell,
I see the config.json now having multiple monitors, which is cool. Where
do we specify the top level properties like app port etc.(i think its not
there in config.json now, unless I did not notice).
Also, how do I launch the URL? Is it a query param to say which monitor ?
My colleague Arun has forked your project and had incorporated few bug
fixes and style changes for our use. I have requested him to work with you
to raise the Pull Requests against your repository so that such
contribution can go to one place :)
Best regards,
Karthik Krishnan.
http://karthiks.in
…On Tue, Aug 1, 2017 at 5:21 PM, Marcell Spies ***@***.***> wrote:
Thank you. Maybe you can give me some input. I'd like to implement an easy
solution first. If possible, without breaking changes for existing
solutions.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXe6pl3zzZGt8PIinIBxT8I0NvqF30hks5sT5bFgaJpZM4Ohg5E>
.
|
Hi, sorry for the late response.
Great, good to know, that your colleague will help. If I find some time tomorrow, I'll resume coding this feature. I hope we won't run into any conflicts. ;-) Kind regards |
@karthik-krishnan suggestion is excellent. Perhaps instead of a separate unique page/tab per monitor, have a single page with a column per configured monitor job. That way you can see them all on the same page by looking left to right and scroll down for build history. |
Hi @marcells, |
Hi, currently there is still some work to do. If someone could continue my (exprrimental) work of feature branch https://github.com/marcells/node-build-monitor/tree/feature/multi-configuration would be good. I have no time at the moment to continue active development of this feature. |
Typically in Enterprises, there are multiple groups of projects monitored and hence each group would have a page for itself. It would be great if one can have multiple config json files and a unique url to render the dashboard based on the specific config.
This allows for us to have multiple tabs in browser (one for each group) and switch them on a timer.
In the current implementation of the node-build-monitor, i will have to run multiple instances of the node app on different ports as a workaround
The text was updated successfully, but these errors were encountered: