Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right-click to copy cell output if nothing is selected #2944

Closed
wasimsandhu opened this issue Nov 23, 2024 · 5 comments · Fixed by #2949
Closed

Right-click to copy cell output if nothing is selected #2944

wasimsandhu opened this issue Nov 23, 2024 · 5 comments · Fixed by #2949

Comments

@wasimsandhu
Copy link
Collaborator

wasimsandhu commented Nov 23, 2024

Describe the bug

Using the latest marimo version, when I right click over a cell's output and select copy, I am expecting the cell's output to be copied to my clipboard. Instead, nothing is copied.

Environment

{
  "marimo": "0.9.23",
  "OS": "Darwin",
  "OS Version": "23.4.0",
  "Processor": "i386",
  "Python Version": "3.12.4",
  "Binaries": {
    "Browser": "131.0.6778.86",
    "Node": "v20.18.0"
  },
  "Dependencies": {
    "click": "8.1.7",
    "docutils": "0.21.2",
    "itsdangerous": "2.2.0",
    "jedi": "0.19.2",
    "markdown": "3.7",
    "narwhals": "1.13.5",
    "packaging": "24.2",
    "psutil": "6.1.0",
    "pygments": "2.18.0",
    "pymdown-extensions": "10.12",
    "pyyaml": "6.0.2",
    "ruff": "0.4.4",
    "starlette": "0.41.2",
    "tomlkit": "0.13.2",
    "typing-extensions": "4.12.2",
    "uvicorn": "0.32.0",
    "websockets": "12.0"
  },
  "Optional Dependencies": {
    "pandas": "2.2.3",
    "pyarrow": "18.0.0"
  }
}

Code to reproduce

No response

@wasimsandhu wasimsandhu added the bug Something isn't working label Nov 23, 2024
@mscolnick
Copy link
Contributor

Can you share a video? I cannot reproduce this.

@wasimsandhu
Copy link
Collaborator Author

wasimsandhu commented Nov 24, 2024

I can't reproduce it anymore either... Not sure what happened. However, I think this issue still stands because I'm unable to right click and copy cell outputs, only cell code.

One possible solution is to provide a different context menu when right clicking cell outputs. Would make it easier to copy and share error outputs too.

@mscolnick
Copy link
Contributor

Are you selecting any text and then right-clicking?

@mscolnick mscolnick removed the bug Something isn't working label Nov 24, 2024
@mscolnick mscolnick changed the title Right-click to copy cell output does not work as expected Right-click to copy cell output if nothing is selected Nov 24, 2024
@mscolnick
Copy link
Contributor

Converting this to a FR, taking a guess at what you were probably trying to do. Let me know if the updated title is correct.

@wasimsandhu
Copy link
Collaborator Author

Yup, looks good thanks. Updated the initial comment too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants