Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deserialize doesnt appear to accept a model #120

Open
mark-lester opened this issue Nov 30, 2015 · 8 comments
Open

deserialize doesnt appear to accept a model #120

mark-lester opened this issue Nov 30, 2015 · 8 comments

Comments

@mark-lester
Copy link

I cant go Syphon.deserialize(view,model);
Is there a reason for that ?

@samccone
Copy link
Member

what would you expect that api call to do?

@happylinks
Copy link

I think he means Syphon.deserialize(view, model.toJSON()). Could be cool if the lib did that automatically.

@mark-lester
Copy link
Author

Ah right, you go toJSON(), yes of course.
OK, I accept anyone who hasnt just landed should know how to do that.

@samccone
Copy link
Member

sure that would be nice, if the item passed implements a toJSON method we call that otherwise we treat it like a regular object :)

@mark-lester @happylinks any interest in opening up a PR?

@mark-lester
Copy link
Author

yes sure

@mark-lester
Copy link
Author

oh ok, well, i will get my formgen working, then if nothing happens on this I will do the biz.
it confused me, it would be nice to go deserialize(this,this.model)

@happylinks
Copy link

Ah sorry, spoke before my turn :) if you want help/me to do it, let me know.

@mark-lester
Copy link
Author

I will do,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants