Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lodash from peerDependencies #141

Open
paulovieira opened this issue Feb 3, 2017 · 3 comments
Open

remove lodash from peerDependencies #141

paulovieira opened this issue Feb 3, 2017 · 3 comments

Comments

@paulovieira
Copy link

package.json has lodash as a peerDependency. What's the reason for that? Backbone.Syphon doesn't use it anywhere in the application code.

@scott-w
Copy link
Member

scott-w commented Feb 3, 2017

Hi @paulovieira

Syphon uses either lodash or underscore. I've left both in for now, though I'm happy for you to submit a PR if you have a preference for how it should be set up.

@paulovieira
Copy link
Author

Hi Scott! I'm a bit confused. I see syphon using only lodash (in the build file), and no sign of lodash:

https://github.com/marionettejs/backbone.syphon/blob/master/lib/backbone.syphon.js#L15

@scott-w
Copy link
Member

scott-w commented Feb 3, 2017

Ahh, yeah it's done at the build file level. For example, in webpack, you can swap out underscore for lodash when you configure the imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants