-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IDs to sections for easy reference #409
Comments
👍 |
@peterblazejewicz Meaning we have to un-hide it for mobile, correct? Just making sure I am on the same page. thanks @trezy for the idea! I'll see you tomorrow at JSConf. |
@jdaudier Yes, just make sure that any header/section with added bookmarkable anchor is visible on all viewports :D |
you got it! |
@peterblazejewicz I disagree. I've verified on several mobile devices -- Android 4.something, Android 4.somethingElse, iOS8, etc -- that the browser just brings you to the top of the homepage if the section is hidden. No unexpected consequences. I'll dig in and add these this weekend since I got the repo to build this time. :-) |
@trezy that's the point - user arepointed nowhere:
|
@peterblazejewicz That's an issue with us hiding sections. If you're concerned with users being penalized then we should make sure all of the sections are available, i.e. not hidden from mobile. That's a completely separate issue. This is an enhancement to make the page more navigable for those that have the capability. |
One of my coworkers asked my yesterday who actually uses Marionette. I just referred him to the list of the bottom of the website but I would rather have been able to send him a link like [http://marionettejs.com/#logos].
The text was updated successfully, but these errors were encountered: