Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move general css styles into separate repo #483

Open
denar90 opened this issue Sep 10, 2016 · 6 comments
Open

Move general css styles into separate repo #483

denar90 opened this issue Sep 10, 2016 · 6 comments

Comments

@denar90
Copy link
Member

denar90 commented Sep 10, 2016

I propose to move global css styles in separate repo. As a result we will have kinda framework which can be used for main site and for blog.
Stuff which can be moved:

Thoughts?

@peterblazejewicz
Copy link
Member

peterblazejewicz commented Sep 10, 2016

Some changes to SCSS structure were loosely based on SASS Guidelines pattern:
https://sass-guidelin.es/#the-7-1-pattern
How do you want to incorporate site and blog changes? Do you think the themes could be used for this?

@scott-w
Copy link
Member

scott-w commented Sep 10, 2016

I totally support this. It'd be great if we can use an explicit license too so people can build plug-ins that have a clear reference point back to Marionette.

@denar90
Copy link
Member Author

denar90 commented Sep 10, 2016

@peterblazejewicz which styles can we use in themes files? Regarding to marionettejs/blog#17 we should make them both in one theme style. So right now I have no clue what to place there...

@scott-w sorry, are you talking about js plugins? Do you wanna people who build Mn plugins use our styles for their doc sites?

@scott-w
Copy link
Member

scott-w commented Sep 11, 2016

For stuff we'd want to bring into the ecosystem or affiliate with Marionette.

@peterblazejewicz
Copy link
Member

@peterblazejewicz which styles can we use in themes files? Regarding to marionettejs/blog#17 we should make them both in one theme style. So right now I have no clue what to place there...

All common should go into abstracts/base and themes. Have you though about snipping common Sass just NPM or Bower GitHub based dependency? It could be installed just like any other dependency and used in site and blog Sass code:
The Zurb's Foundation installs Sass sources as Bower dependency that are later configured to be included in Sass configuration:
http://foundation.zurb.com/

# RUBY
# Require any additional compass plugins here.
add_import_path "bower_components/foundation/scss"
// Node/Grunt
sass: {
      options: {
        includePaths: ['bower_components/foundation/scss']
      },
      dist: {
        options: {
          outputStyle: 'compressed',
          sourceMap: true,
        },
        files: {
          'css/app.css': 'scss/app.scss'
        }
      }
    },

@denar90
Copy link
Member Author

denar90 commented Sep 11, 2016

@scott-w thanks, got it 👍
@peterblazejewicz yeah, was thinking to do it in similar way, but was frustrated by themes folder.

I'll try to create some repo maybe we can review it and talk about structure and all stuff in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants