Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping .NET Standard 1.6 #208

Closed
0xced opened this issue Sep 14, 2021 · 5 comments
Closed

Consider dropping .NET Standard 1.6 #208

0xced opened this issue Sep 14, 2021 · 5 comments
Assignees
Milestone

Comments

@0xced
Copy link
Contributor

0xced commented Sep 14, 2021

I have started simplifying the projects and I noticed that almost all of conditional compilation (#if COREFX) is actually because of the .NET Standard 1.6 target framework.

So, would you consider dropping support for .NET Standard 1.6 in the next release? That would simplify a lot of things.

@mariotoffia
Copy link
Owner

mariotoffia commented Sep 15, 2021

Hi @0xced, yes, the plan is to drop it in the next major (3.0.0) release.

@0xced
Copy link
Contributor Author

0xced commented Sep 15, 2021

Good to know! Should I submit a pull request on the master branch or are you planing to create a new v3 branch?

@0xced
Copy link
Contributor Author

0xced commented Sep 15, 2021

Anyway, I have opened #209 which simplifies the projects without modifying the supported target frameworks. Il will be easy to drop .NET Standard 1.6 as I explained in the comments of this pull request.

@mariotoffia
Copy link
Owner

Thanks for the pr - it will be super easy to remove 1.6 later on!

@mariotoffia mariotoffia added this to the 4.0.0 milestone Sep 15, 2021
@mariotoffia
Copy link
Owner

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants