-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for docker compose v2.0.0 incl. using dock binary instead of docker-compose #221
Comments
Hi @Ross-Duckworth-Pharos and thanks for reporting this! I will add the possibility to AssumeComposeVersion / AutoDetect so it could use different strategies depending on version. (another task is actually to allow for Cheers, |
Docker-Compose v1 has been deprecated, and we should all switch to docker compose v2 Any ideas as to when this can be supported? |
As a potential quick fix: edit: |
Docker provide Compose Switch, which translates calls made to the old V1 This PR allows the compose version to be specified to ensure the correct parsing logic is used, which combined with Compose Switch means FluentDocker is able to work with the latest Compose version. |
Just hit this same issue, is there a path forward |
There's a setting so you can specify the compose version AssumeComposeVersion(ComposeVersion.V2) Default is Unknown and hence falls back to V1 behavoiur. This behaviour will be deprecated and migrated to default as V2 this year. Cheers, |
This does not seem to work when passing a docker-compose.yml file through DockerComposeCompositeService.
But it's still using V1 unfortunately |
The recently released Docker Compose V2 (https://github.com/docker/compose/releases/tag/v2.0.0) introduces the following change: container names use hyphens to produce a valid hostname
This breaks the container name parsing in
ExtractName
inDuctus.FluentDocker/Services/Impl/DockerComposeCompositeService.cs
which assumes underscores are being used (now hyphens are).The text was updated successfully, but these errors were encountered: