Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BeforeContainerInitialized in FluentDockerTestBase ctor #257

Closed
miketof opened this issue May 25, 2022 · 2 comments
Closed

Add BeforeContainerInitialized in FluentDockerTestBase ctor #257

miketof opened this issue May 25, 2022 · 2 comments
Assignees
Milestone

Comments

@miketof
Copy link

miketof commented May 25, 2022

derived ctor is called after the FluentDockerTestBase ctor so basically, the OnContainerInitialized can be used exchangeable with ctor of the inherited class. But if I want to do some operation before Build and Start - I can't. That's my proposition is to implement BeforeContainerInitialized() virtual method as the first line of FluentDockerTestBase ctor.

@mariotoffia mariotoffia self-assigned this Jun 7, 2022
@mariotoffia mariotoffia added this to the 3.0.0-RELEASE milestone Jun 7, 2022
@mariotoffia
Copy link
Owner

Thanks @miketof - I'll add it to my TODO list.

Thanks!
Mario :)

mariotoffia added a commit that referenced this issue Jun 23, 2022
@mariotoffia
Copy link
Owner

Hi @miketof I've added several methods to participate in before build and before start - including before dispose (on error or test tear down).

Cheers,
Mario :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants