Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to run on updated version of urfave/cli #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

l3x
Copy link

@l3x l3x commented May 13, 2021

[]cli.Command was changed to []*cli.Command in v2

These changes resolve #3

@marouni
Copy link
Owner

marouni commented May 13, 2021

@l3x Any idea why the build is failing ?

@l3x
Copy link
Author

l3x commented May 13, 2021

Yes. I believe it's because the Go module PR locked the urfave/cli version at v1.20.0.

I've noticed others have run into this issue and it's likely because most people are running Go, relying on GOPATH to resolve the dependencies: That'll grab the latest versions-- urfave/cli is on version 2 -- which breaks b/c the existing adr code depends on version 1.x syntax in two places.

I noticed that Travis executes export GO111MODULE="on" to turn on Go Module support prior to running go build ./

You can see the Travis build log here.

A reasonable solution would be to update the go.mod and go.sum files to match a more current release.

If you're not in a hurry, I can look at updating that this weekend.

In the meantime, folks complaining about errors installing adr can run export GO111MODULE="on" before installing adr.

@marouni
Copy link
Owner

marouni commented May 14, 2021

@l3x

If you're not in a hurry, I can look at updating that this weekend.
That sounds awesome, this way it will fix the issue out of the box.
Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing Go adr
2 participants