Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple silicon GitHub hosted runner #509

Merged

Conversation

GreyTeardrop
Copy link

Pulling @rgoldberg changes from #508.

@GreyTeardrop
Copy link
Author

@rgoldberg the workflow is paused and needs an approval.

@rgoldberg
Copy link
Contributor

@GreyTeardrop Thanks. Approved. Check running now.

@rgoldberg rgoldberg requested review from rgoldberg and removed request for rgoldberg February 5, 2024 23:42
@rgoldberg
Copy link
Contributor

rgoldberg commented Feb 5, 2024

@GreyTeardrop Can you request that I review this PR?

I already approved, but that only ran the checks, which all passed, but merging is still blocked. Either mas-cli/admins must approve to merge, or you need to request a review from me, then I need to approve it. I assume the former is the case, but it won't hurt to try a review request from you to me.

@GreyTeardrop
Copy link
Author

Nope, I don't have an option to request any review :-(

@rgoldberg
Copy link
Contributor

@GreyTeardrop Sorry, didn't know you wouldn't be able to request a review. I self-requested, but didn't see an option to approve the self-request. I'll try to get more permissions…

Copy link
Member

@phatblat phatblat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thanks, @GreyTeardrop

@phatblat phatblat merged commit ec503a1 into mas-cli:main Feb 17, 2024
5 checks passed
@GreyTeardrop GreyTeardrop deleted the apple-silicon-github-hosted-runner branch February 17, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants