-
-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pm2 ecosystem file icon #2708
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Amir Farzamnia <[email protected]>
Signed-off-by: Amir Farzamnia <[email protected]>
PreviewThank you for creating a pull request. This preview shows you how your icon will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few issues.
- The icon doesn't use de material color palette
- It doesn't have margins (we usually design icons at 16x16 -or a multiple of 16x16, like 32x32, etc- with at least 1px of margin; designing your icon using a 1:1 viewport will help you!
- Ideally, the icon should be aligned to a 16x16 grid. It's going to be hard for this one, but at least straight horizontal lines can be aligned
Please read the Contributing guide for more details.
Also, it seems to me that there are too many details in this icon |
Description
Closes: #2707
Contribution Guidelines