Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pm2 ecosystem file icon #2708

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amirfarzamnia
Copy link

@amirfarzamnia amirfarzamnia commented Nov 14, 2024

Description

Closes: #2707

Contribution Guidelines

Signed-off-by: Amir Farzamnia <[email protected]>
Signed-off-by: Amir Farzamnia <[email protected]>
@github-actions github-actions bot added the icons PR with new icons label Nov 14, 2024
Copy link
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

Copy link
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few issues.

  • The icon doesn't use de material color palette
  • It doesn't have margins (we usually design icons at 16x16 -or a multiple of 16x16, like 32x32, etc- with at least 1px of margin; designing your icon using a 1:1 viewport will help you!
  • Ideally, the icon should be aligned to a 16x16 grid. It's going to be hard for this one, but at least straight horizontal lines can be aligned

Please read the Contributing guide for more details.

@lucas-labs lucas-labs changed the title Added PM2 ecosystem icon feat: pm2 ecosystem file icon Nov 15, 2024
@okineadev
Copy link
Member

There are a few issues.

  • The icon doesn't use de material color palette
  • It doesn't have margins (we usually design icons at 16x16 -or a multiple of 16x16, like 32x32, etc- with at least 1px of margin; designing your icon using a 1:1 viewport will help you!
  • Ideally, the icon should be aligned to a 16x16 grid. It's going to be hard for this one, but at least straight horizontal lines can be aligned

Please read the Contributing guide for more details.

Also, it seems to me that there are too many details in this icon

@lucas-labs
Copy link
Member

image
image

I made this simplified version... it doesn't have all the details from the original as I tried to optimize it to be rendered at 16px

What do you guys think?

@amirfarzamnia
Copy link
Author

image image

I made this simplified version... it doesn't have all the details from the original as I tried to optimize it to be rendered at 16px

What do you guys think?

This is great. We really need an ecosystem.config.* icon for the projects relying on PM2. I think this is great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons PR with new icons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request]: ecosystem.config.js
3 participants