Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Rstruct.v #1014

Open
affeldt-aist opened this issue Aug 22, 2023 · 2 comments
Open

improve Rstruct.v #1014

affeldt-aist opened this issue Aug 22, 2023 · 2 comments
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Milestone

Comments

@affeldt-aist
Copy link
Member

It turns out that Rstruct.v was useful in PR #1002 and is also useful in porting results from infotheo (https://github.com/affeldt-aist/infotheo) to MathComp-Analysis but the file has not been maintained as well as other files. Improvements are welcome.

@affeldt-aist affeldt-aist added the good first issue This should be a problem easy to tackle by a beginner label Aug 22, 2023
@affeldt-aist
Copy link
Member Author

We have been using more extensively Rstruct.v for infotheo.0.6.0.
In particular, @t6s realized that we can now use the following, easier lemmas about Rinv and Rdiv: https://github.com/affeldt-aist/infotheo/blob/master/lib/ssrR.v#L642C1-L652C37
This can already be PRed as an improvement.
More generally, we should maybe reflect a bit on what we did with infotheo to PR a bit more improvements.
For example, real_realType is a bit longish for an identifier.
A multirule such as https://github.com/affeldt-aist/infotheo/blob/master/lib/ssrR.v#L657
might also be an improvement.
Should the lemmas about bigop also be part of the PR?
Mayve sumRE should not even exist but I am less sure about bigmaxRE.

@affeldt-aist affeldt-aist added this to the 1.3.0 milestone Jun 17, 2024
@affeldt-aist
Copy link
Member Author

Note that this (now merged PR) already introduced a few improvements: #1235

@affeldt-aist affeldt-aist modified the milestones: 1.3.0, 1.4.0 Jul 19, 2024
@affeldt-aist affeldt-aist modified the milestones: 1.4.0, 1.5.0 Sep 19, 2024
@affeldt-aist affeldt-aist modified the milestones: 1.5.0, 1.6.0 Oct 8, 2024
@affeldt-aist affeldt-aist modified the milestones: 1.6.0, 1.7.0 Oct 23, 2024
@affeldt-aist affeldt-aist modified the milestones: 1.7.0, 1.8.0 Nov 22, 2024
@affeldt-aist affeldt-aist added enhancement ✨ This issue/PR is about adding new features enhancing the library and removed good first issue This should be a problem easy to tackle by a beginner labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

No branches or pull requests

1 participant