Implement key backup APIs for rust and create backup in bootstrapSecretStorage
#3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
changed the title
BillCarsonFr
force-pushed
the
valere/element-r/keybackup_reset_api_rust
branch
from
4d7b7b5 to
dcdbbee
Compare
BillCarsonFr
requested review from
richvdh and
weeman1337
and removed request for
weeman1337
3 tasks
BillCarsonFr
force-pushed
the
valere/element-r/keybackup_reset_api_rust
branch
from
dcdbbee to
dc7a029
Compare
BillCarsonFr
changed the base branch from
develop
to
valere/element-r/keybackup_reset_api
richvdh
changed the title
richvdh
changed the title
richvdh
requested changes
Sep 4, 2023
spec/integ/crypto/crypto.spec.ts
Outdated
Comment on lines
2205
to
2209
|
|
||
| if (content.key) { | ||
| resolve(content.key); | ||
| } | ||
|
|
There was a problem hiding this comment.
not convinced this is an improvement, but ymmv
There was a problem hiding this comment.
not sure I touched that, I am a bit confused
Base automatically changed from
valere/element-r/keybackup_reset_api
to
develop
September 4, 2023 20:13
richvdh
changed the title
bootstrapSecretStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/vector-im/crypto-internal/issues/107
Based on #3689Implements missing key backup API in rust and create backups as part of the bootstrap security process
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.