Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide better error for ICE Server SyntaxError #3694

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Provide better error for ICE Server SyntaxError #3694

merged 3 commits into from
Sep 5, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 5, 2023 •
edited by github-actions bot
Loading

Fixes element-hq/element-web#21804

Here's what your changelog entry will look like:

🐛 Bug Fixes

@t3chguy t3chguy marked this pull request as ready for review September 5, 2023 11:32
@t3chguy t3chguy requested a review from a team as a code owner September 5, 2023 11:32
SimonBrandner
SimonBrandner reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I am struggling to see when getUserMedia would fail with SyntaxError - what am I missing? How is this related ICE, are there any docs for this?

@t3chguy
Copy link
Member Author

t3chguy commented Sep 5, 2023

It isn't getUserMedia - its placeCallWithCallFeeds - guess can rearrange the code for clarity

SimonBrandner
SimonBrandner approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t3chguy t3chguy enabled auto-merge September 5, 2023 14:17
@t3chguy t3chguy added this pull request to the merge queue Sep 5, 2023
Merged via the queue into develop with commit 8e0ef98 Sep 5, 2023
20 checks passed
@t3chguy t3chguy deleted the t3chguy/fix/d1197 branch September 5, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBrandner SimonBrandner SimonBrandner approved these changes

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid STUN / TURN URL from HS causes call to fail with confusing media permission error
2 participants
@t3chguy @SimonBrandner