Fix potential delay in sending out requests from the rust SDK #3717
Conversation
This now happens as a side-effect of importing the keys.
There was a potential race which could cause us to be very slow to send out pending HTTP requests, particularly when handling a user verification. Add some resiliece to make sure we handle it correctly.
| @@ -1304,6 +1311,8 @@ export class RustCrypto extends TypedEventEmitter<RustCryptoEvents, RustCryptoEv | |||
| throw new Error("missing roomId in the event"); | |||
| } | |||
|
|
|||
| logger.debug(`Incoming verification event ${event.getId()} type ${event.getType()} from ${event.getSender()}`); | |||
There was a problem hiding this comment.
this was just some really useful debugging which I'm throwing in while I'm in the area.
richvdh
requested review from
dbkr and
weeman1337
and removed request for
a team
|
Updated from develop to make the diff clearer, since the based-on PR is merged. (Hope that's ok) |
| return; | ||
| } | ||
| this.outgoingRequestLoopInner().catch((e) => { |
There was a problem hiding this comment.
Worth a comment saying we are deliberately not awaiting this here?
| this.outgoingRequestLoopRunning = true; | ||
| try { | ||
| while (!this.stopped) { | ||
| this.outgoingRequestLoopOneMoreLoop = false; |
There was a problem hiding this comment.
Can you add another short comment here? Because if you oversee the await one may think that this.outgoingRequestLoopOneMoreLoop is always false in the if below.
|
I've added some comments, and a unit test. A proper integration test is a pain in the butt. |
There was a potential race which could cause us to be very slow to send out pending HTTP requests, particularly when handling a user verification. Add some resilience to make sure we handle it correctly.
Based on #3716This change is marked as an internal change (Task), so will not be included in the changelog.