Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rip out SFU bits out of MSC3401 #3897

Merged
merged 4 commits into from
Oct 21, 2022

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Sep 25, 2022

MSC3401 is already large and there are a lot of SFU bits that are missing in it and would need to be added therefore it makes more sense to rip out the SFU bits into a separate MSC (see #3898)

This MSC is already large and there are a lot of SFU bits that are missing in it and would need to be added therefore it makes more sense to rip out the SFU bits into a separate MSC

Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner marked this pull request as ready for review September 25, 2022 17:41
@SimonBrandner SimonBrandner requested review from ara4n and dbkr September 29, 2022 13:58
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this seem fine, but I think I'd agree with Matthew in that we could probably just refer to this MSC for all the diagrams, if possible

Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Copy link
Contributor Author

I've now moved all the diagrams into MSC3401 and link to it from MSC3898. @ara4n, does that look good to you?

@SimonBrandner SimonBrandner requested a review from dbkr October 19, 2022 14:05
@SimonBrandner SimonBrandner merged commit 32f566a into matthew/group-voip Oct 21, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/group-voip-sfu-rip branch October 21, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants