Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Similarity search based on dot product #37

Open
fullflu opened this issue Jul 8, 2020 · 3 comments
Open

Similarity search based on dot product #37

fullflu opened this issue Jul 8, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@fullflu
Copy link

fullflu commented Jul 8, 2020

Hi @matsui528 ,
Thank you for releasing such an awesome library.

Now I want to implement a subset search system based on dot product.
Do you have any plans to develop such algorithms?

I found that annoy implements similarity search algorithms using dot product, but it did not focus on the subset search.
https://github.com/spotify/annoy/blob/84f1c68e43b41daf1ce22c1eb4f3a8d3e0086403/src/annoylib.h#L505

@matsui528
Copy link
Owner

I didn't plan to implement a dot-product functionality, but it may be useful for some cases. Let me check my code, and I'll implement it if it turns out that it's easy to code...

@matsui528 matsui528 added the enhancement New feature or request label Jul 9, 2020
@fullflu
Copy link
Author

fullflu commented Jul 11, 2020

Thank you for your response.
I understand your plan. I'll use other methods for a while, but I’m looking forward to your implementation of the dot product similarity (if possible).

@matsui528
Copy link
Owner

It turned out that it's not trivial to implement the IP search functionality 😰 Waiting for PR, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants