Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider symphonia in the future #2

Open
m4b opened this issue Feb 12, 2024 · 2 comments
Open

consider symphonia in the future #2

m4b opened this issue Feb 12, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@m4b
Copy link

m4b commented Feb 12, 2024

Hello,

First off, incredible project; this is just what i wanted; a simple cli waveform viewer. i get tired of opening and closing audacity over and over just to see what a waveform looks like, etc.

One minor issue is that this is harder to build on e.g., macos, etc., due to dependency on libsoundfile.

While not as robust, symphonia (https://github.com/pdeljanov/Symphonia/blob/master/symphonia/examples/getting-started.rs) may get you to a most of the way there pure to a rust solution. I suspect they will do a new release soon, which has even more codecs and containers, etc.

Anyway, thanks for the great project! also, one last thing, you're missing 4 channel containers, and there is a minor typo; simple patch is here:

--- a/src/render/metadata.rs
+++ b/src/render/metadata.rs
@@ -80,7 +80,8 @@ fn channel_layout_to_string(channels: usize) -> String {
     match channels {
         1 => "mono",
         2 => "stereo",
-        3 => "ambinosic 2.1",
+        3 => "ambisonic 2.1",
+        4 => "quadrophonic",
         5 => "ambisonic 5",
         6 => "ambisonic 5.1",
         7 => "ambisonic 7",
@maxmarsc
Copy link
Owner

Glad to hear it helps ! I'll try to look into it this weekend. I might not integrate Symphonia right now but good to know thanks (I'm a bit busy at the moment)

@maxmarsc
Copy link
Owner

maxmarsc commented Feb 24, 2024

@m4b The quadrophonic support has been added to v0.2.1

I haven't had time to check Symphonia yet (I'm really rusty with rust, no pun intended). It's going to take a bit more of my free time, but I'll let you know.

I just realized I didn't fixed the typo 😂 I guess it will be for the next version

@maxmarsc maxmarsc added the enhancement New feature or request label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants