Add support for touch events to violent theremin demo #126
Comments
|
Would it be ok to take this on and give it a bit of a re-write (inc touch events) and also move it into the webaudio-examples repo @chrisdavidmills ? |
|
@Rumyra yes, I'm fine with that. It is mentioned a few times on MDN, so make sure there is some kind of redirect in place. |
|
Thank you! Yep I think I'm going to roll it into a bigger task of auditing audio, so I'm hoping that won't be too much of a problem 👍 |
github-actions
bot
added
the
needs triage
sideshowbarker
removed
the
needs triage
This comment was marked as outdated.
This comment was marked as outdated.
|
Hi all, I saw an opportunity to work on this issue and decided to pick it up. I've just opened #128. Feel free to provide feedback or suggest changes—I'm happy to discuss and make any needed adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@normanr commented on Wed Dec 02 2020
It would be nice to be able to use the demo in a touch environment (eg: phone or tablet). (Not required: sound could be continuous after a 'start/down' event until an 'end/up' event is received)
@chrisdavidmills commented on Wed Dec 02 2020
I agree that this would be nice.
For reference:
@normanr commented on Wed Dec 02 2020
(side-note: the event listeners for triggering
initshould be removed ininit, otherwise using the keyboard causes init to be triggered multi times, andDOMExceptionswhen trying to remove thestartMessagethat has already been removed).The text was updated successfully, but these errors were encountered: