Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: how can we support eslint-define-config better? #526

Open
4 tasks done
JounQin opened this issue Jan 22, 2024 · 6 comments
Open
4 tasks done

meta: how can we support eslint-define-config better? #526

JounQin opened this issue Jan 22, 2024 · 6 comments
Labels
help wanted 🙏 This could use your insight or help internal :house: Internal meta

Comments

@JounQin
Copy link
Member

JounQin commented Jan 22, 2024

Initial checklist

Problem

mdx support was added at eslint-types/eslint-define-config#124, but somehow it's removed later?

I hope the end users can use eslint-plugin-mdx with typings support easily.

cc @Shinigami92

Solution

I'm not quite familiar with eslint-define-config, so I'd prefer to listening from experienced @Shinigami92

Alternatives

N/A

@JounQin JounQin added help wanted 🙏 This could use your insight or help internal :house: Internal meta labels Jan 22, 2024
@Shinigami92
Copy link

There needs to be a file that can be imported via ref like /// <reference types="eslint-plugin-mdx/define-config-support" />

In that file it should look like e.g. https://github.com/eslint-types/define-config-plugin-types/blob/main/types/import/index.d.ts

@JounQin
Copy link
Member Author

JounQin commented Jan 22, 2024

Can that be supported from eslint-plugin-mdx's side natively?

@Shinigami92
Copy link

Can that be supported from eslint-plugin-mdx's side natively?

YES, thats why these global augmentations are there.

@JounQin
Copy link
Member Author

JounQin commented Jan 22, 2024

Would you to raise a PR here? I'd to get some experiences here and then use it on eslint-pligin-i later. ❤️

@Shinigami92
Copy link

Would you to raise a PR here? I'd to get some experiences here and then use it on eslint-pligin-i later. ❤️

Yeah, I can try 👍
Not sure when, but I will try to set it on my list for this week

@JounQin
Copy link
Member Author

JounQin commented Jan 22, 2024

It's not in emergency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted 🙏 This could use your insight or help internal :house: Internal meta
Development

No branches or pull requests

2 participants