You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I searched issues and couldn’t find anything (or linked relevant results below)
Affected packages and versions
eslint-plugin-mdx-3.1.5
Link to runnable example
No response
Steps to reproduce
The following contents report
**:2 warning Unused eslint-disable directive (no problems were reported)
**:7 error 'deployProjectCommand' is never reassigned. Use 'const' instead prefer-const
{/* eslint-disable prefer-const */}
```ts
import { CommandRegister } from "@foo";
export function registerCommands(commandRegister: CommandRegister) {
let deployProjectCommand: DeployProjectCommand = new DeployProjectCommand();
commandRegister.addCommand(deployProjectCommand);
}
```
{/* eslint-enable prefer-const */}
Whereas this is correctly ignoring the linting error.
```ts
{/* eslint-disable prefer-const */}
import { CommandRegister } from "@foo";
export function registerCommands(commandRegister: CommandRegister) {
let deployProjectCommand: DeployProjectCommand = new DeployProjectCommand();
commandRegister.addCommand(deployProjectCommand);
}
{/* eslint-enable prefer-const */}
```
Expected behavior
Both should correctly suppress the linting error.
Actual behavior
Only eslint-disables inside the block suppress the error. This means that the eslint-disable comment is visible inside the codeblock.
I've searched through issues and haven't found anything directly related to this, but given the response here this might be something from a dependency - if someone can confirm this, I'm happy to raise it there alternatively.
Runtime
Node v20
Package manager
yarn v1
OS
macOS
Build and bundle tools
Docusaurus
The text was updated successfully, but these errors were encountered:
@btmills Is that possible to support jsx style comments for .mdx files? Otherwise I have to copy-paste eslint-plugin-markdown's source codes instead which I'd like to avoid.
MDXv2 moved away from HTML comments, so anything that's using MDX as it's backing (e.g. Docusaurus) would need to support JSX comments. I'd suggest extending this to .md files too, but there are probably other stacks out there that might need it too.
EDIT: Also, it doesn't work in overrides. This doesn't work:
Initial checklist
Affected packages and versions
eslint-plugin-mdx-3.1.5
Link to runnable example
No response
Steps to reproduce
The following contents report
**:2 warning Unused eslint-disable directive (no problems were reported)
**:7 error 'deployProjectCommand' is never reassigned. Use 'const' instead prefer-const
Whereas this is correctly ignoring the linting error.
Expected behavior
Both should correctly suppress the linting error.
Actual behavior
Only
eslint-disable
s inside the block suppress the error. This means that theeslint-disable
comment is visible inside the codeblock.I've searched through issues and haven't found anything directly related to this, but given the response here this might be something from a dependency - if someone can confirm this, I'm happy to raise it there alternatively.
Runtime
Node v20
Package manager
yarn v1
OS
macOS
Build and bundle tools
Docusaurus
The text was updated successfully, but these errors were encountered: