Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyType as a string ? #1

Open
Foxxat opened this issue Jul 1, 2021 · 0 comments
Open

PropertyType as a string ? #1

Foxxat opened this issue Jul 1, 2021 · 0 comments

Comments

@Foxxat
Copy link

Foxxat commented Jul 1, 2021

Really handy library !. Have been battling for a couple of hours with something so putting a note here.

The types for PropertyType are spot on for the enums - however Zoopla also support a string ontop of the enum list.
From the ZPG spec If you believe that there is a significant difference between your property type and those that we support, then send your property type as a readable string. In such cases we will display property type as "Property"
I've been attempting to send a property without using an enum and do not think this library allows for it.

To get around this I ended up creating a new propertyType of Property => property just to be able to send it. This then fails validation on the validation routine, so I've ended up adding a final parameter to sendProperty(param1,2,3 etc, .. $skip_validation) which (temporarily to get around this) lets me skip the validation.

Any thoughts on how to include this somewhat lax feature in the spec in a better way ?
Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant