Make the error returned by the BytesDecode/BytesEncode trait customizable #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt at getting rid of the
BoxedError
type we currently use everywhere.That allows us to use a « real » type when an error arises in the
BytesEncode
orBytesDecode
traits.The new traits
I called the type
Err
to do something similar to theFromStr
trait from the stdlib.The new
Error
enumI had to make the
Error
enum generic over the decoding and encoding error.For most functions, that do not add any complexity because we use our
Result
type;That set
E
andD
toInfallible
by default.My issue
For some methods like the following one, we can return an error while encoding the key OR the value + while decoding the key OR the value:
One solution could be adding two other variants to the
Error
enum.