Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme or plugin CSS could interfere with Foyer's styling #23

Open
mennolui opened this issue Apr 7, 2018 · 3 comments
Open

Theme or plugin CSS could interfere with Foyer's styling #23

mennolui opened this issue Apr 7, 2018 · 3 comments

Comments

@mennolui
Copy link
Owner

mennolui commented Apr 7, 2018

Most notably the body, figure, img, iframe and video elements.

@mennolui
Copy link
Owner Author

mennolui commented Apr 7, 2018

Add some resets to the Foyer CSS?

@mennolui
Copy link
Owner Author

Workarounds used so far:

Themes adding a scrollbar, visible on Edge even when no scrolling needed:

html {
  overflow-y: auto !important;
}

Themes adding bars above/below every page:

body.single-foyer_display, body.single-foyer_channel, body.single-foyer_slide {
    padding: 0 !important;
}

@mennolui
Copy link
Owner Author

Maybe don't fix theme conflicts, but stop loading theme/plugin CSS/JS altogether? Then load it for certain slide formats only, that need to render website content (Post slide, HTML/shortcode slide), and load those slides within their own iframe to isolate CSS/JS problems from the rest and fix #29 along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant