Publish release artifacts with manifests

[lentzi90]

What steps did you take and what happened:

As seen in metal3-io/metal3-docs#414 we are not setting the image tag in the manifests. This is fine for the main branch, but it is not ideal for release branches and tags.
I think we should set the image tag always on release branches to the same as the release branch and for tags to the exact tag.
Otherwise a user trying to apply manifests from release-0.6 for example, will end up with the latest container image from main.

We should publishing release artifacts where the correct image tag is used. Currently we have a default config mixed in with the manifests. This does not make sense to include in the release artifacts IMO. We should handle it the same as the secrets. I.e. the manifests expect the configmap to exist but it is up to the user to create/add it in some way.

With that fixed I think we can do release artifacts and set the image there.

What did you expect to happen:

When using manifests from a specific branch or tag, the corresponding container image should be used.
We should probably include this in the release process.

/kind bug

[Rozzii]

/triage accepted

[Rozzii]

/help

[7h3-3mp7y-m4n]

hey I would like to contribute to it if someone has not picked it up yet

[lentzi90]

Go for it!
/assign @7h3-3mp7y-m4n

[babugeet]

/assign

[babugeet]

@lentzi90 : should we do it for previous release branches as well , or current one only?
Also if we hardcode the value lets say for next release, we take it as v0.6.1, would this need to be updated in every release.
Isnt there a way to automate this one ?

[lentzi90]

@babugeet are you working together with @7h3-3mp7y-m4n ? If not, please let @7h3-3mp7y-m4n get a chance to work on this first.

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[tuminoid]

/remove-lifecycle stale

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[tuminoid]

Should we close this issue or #2089 as both of them are the same, if we ignore the first proposed solution here, which we declined?

Which one to close? This one is older but also more confusing, the latter is clearer as it only has the one accepted solution detailed.

@lentzi90

[Rozzii]

As I have commented for #2089 I would keep the older issue.
I would update this issue and add your description @tuminoid here to extend the old issue .

[Rozzii]

/remove-lifecycle stale

[lentzi90]

Ok if we are going to do this with release artifacts we will need to do some more changes. The tricky part is that we cannot include configuration in the release artifacts. Currently we have a default config mixed in with the manifests. This does not make sense to include in the release artifacts IMO. We should handle it the same as the secrets I think. I.e. the manifests expect the configmap to exist but it is up to the user to create/add it in some way.

With that fixed I think we can do release artifacts and set the image there. (Side note: we should then use those release artifacts in CAPM3 e2e also.)

Edit: I realize I didn't explain why it may be tricky to do this. It is because of metal3-dev-env. It directly modifies the default config here: https://github.com/metal3-io/metal3-dev-env/blob/0b07f57d8bc1fe9596c748b58ac01c75f6eb93d6/03_launch_mgmt_cluster.sh#L64-L70
Perhaps not "hard" to do it differently, but this affects a lot of things.

[tuminoid]

As I have commented for #2089 I would keep the older issue. I would update this issue and add your description @tuminoid here to extend the old issue .

Let's just make it absolutely clear what this ticket is about. So remove the other option and put in the Lennarts comment etc. It also does not sound that it is good first issue anymore, so adjust the labels accordingly.

[lentzi90]

/remove-help