[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kashifest for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Hi @7h3-3mp7y-m4n. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

Thanks for the PR! Please set the PR type to :seedling in the title. I'll review this shortly after all basic tests pass.

Sorry for the delay, as I see markdownlint and shellcheck are the recheck ones, I will raise a PR soon with a fix.

/retest

@tuminoid can you tell me what I am missing here? cause I'm confused

Let's run a retest so we can have fresh logs, the old logs have expired already.

/retest

@7h3-3mp7y-m4n: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.

@tuminoid can you tell me what I am missing here? cause I'm confused

Please check the details links of shellcheck and markdownlint for details what is failing.

For the markdownlink checker failure, I'm not sure what that is complaining about as it just says "action failed" with no logs, I'll look into that.

@tuminoid can you tell me what I am missing here? cause I'm confused

Please check the details links of shellcheck and markdownlint for details what is failing.

For the markdownlink checker failure, I'm not sure what that is complaining about as it just says "action failed" with no logs, I'll look into that.

Thanks @tuminoid I'll look into that

Are you still working on this @7h3-3mp7y-m4n ?

oh, my bad, I'll fix it , I thought that it has been merged , but my bad , I'll fix the ci fails

I actually wrote some review comments here, and then realized this is not the right thing to do, and discussed with @kashifest and @adilGhaffarDev what we should actually be doing. We don't want to have them committed to the repo, but we should set the tags in release artifacts. So I filed issue to actually start including some release artifacts in BMO, such as manifests, where we do need to set the version.

Let's continue the discussion there what we need to include, especially considering IRSO will take Ironic manifests out of BMO shortly.

This PR is not going to be merged, but thanks @7h3-3mp7y-m4n for raising the issue.
/hold

I actually wrote some review comments here, and then realized this is not the right thing to do, and discussed with @kashifest and @adilGhaffarDev what we should actually be doing. We don't want to have them committed to the repo, but we should set the tags in release artifacts. So I filed issue to actually start including some release artifacts in BMO, such as manifests, where we do need to set the version.

Let's continue the discussion there what we need to include, especially considering IRSO will take Ironic manifests out of BMO shortly.

This PR is not going to be merged, but thanks @7h3-3mp7y-m4n for raising the issue. /hold

for sure!

/close

@tuminoid: Closed this PR.