-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LLDP collection in bmh #1731
Comments
I'm generally in favour of this idea but I'd like a design proposal on it since it adds API. I'd rather not see API that simply exposes everything that Ironic collects as raw information. |
/triage accepted |
I am fine with putting the LLDP data to the hardwareData, what about you @dtantsur ? |
It depends on how much you want to add, really. If it's just a couple of fields, I'm good with that. |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
User Story
since ironic allows you to configure LLDP collection, you should similarly be able to enter LLDP values in bmh status.
see your network topology, understand the physical connections between devices, and troubleshoot more efficiently.
Detailed Description
since LLDP information is collected at the ironic inspection stage, I think it should be collected at the same timing as HardwareData.
Anything else you would like to add:
#1227
If a new CR (ex. network discovery) is created, will a new controller be needed?
when I looked at the code again recently, I thought that going similar to PR would be the easiest direction without any changes.
/kind feature
The text was updated successfully, but these errors were encountered: