Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove files from the project #2085

Open
matthewei opened this issue Nov 26, 2024 · 9 comments
Open

Remove files from the project #2085

matthewei opened this issue Nov 26, 2024 · 9 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Milestone

Comments

@matthewei
Copy link

User Story
I found that there are some files that have nothing to do with this project. In order to make the project more standardized, it is recommended to remove these files.

Detailed Description

remove the resources dir

image

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind feature

@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Nov 26, 2024
@dtantsur
Copy link
Member

Maybe we could move the keepalived container to https://github.com/metal3-io/utility-images now that we have it. I agree, having it in BMO is not very intuitive.

@tuminoid
Copy link
Member

Maybe we could move the keepalived container to https://github.com/metal3-io/utility-images now that we have it. I agree, having it in BMO is not very intuitive.

Agreed, and also IRSO will rip out Ironic parts out of here, also not really belonging here.

Utility images could also house ironic-client, which is more or less abandoned in its current repo?

@dtantsur
Copy link
Member

Utility images could also house ironic-client, which is more or less abandoned in its current repo?

It's not really abandoned, it just rarely needs changes (although we should somehow rebuild it periodically).

@tuminoid
Copy link
Member

Utility images could also house ironic-client, which is more or less abandoned in its current repo?

It's not really abandoned, it just rarely needs changes (although we should somehow rebuild it periodically).

True, but with such low traffic most changes are CI related, which could be avoided if it was part of utility images. Alternatively, I could see it part of ironic repo itself as it is a debugging tool for that?

@dtantsur
Copy link
Member

Good point, maybe having it in Ironic is the most meaningful approach.

@Rozzii
Copy link
Member

Rozzii commented Dec 4, 2024

/triage accepted
On community meeting we have agreed that ironic-client will be moved to ironic-image repo and keepalived will be moved to utilty-images.

We have agree that keepalived can be moved after the 0.9 BMO release.

/triage accepted
/help

@metal3-io-bot
Copy link
Contributor

@Rozzii:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted
On community meeting we have agreed that ironic-client will be moved to ironic-image repo and keepalived will be moved to utilty-images.

We have agree that keepalived can be moved after the 0.9 BMO release.

/triage accepted
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 4, 2024
@Rozzii Rozzii moved this from Backlog to BMO WIP in Metal3 - Roadmap Dec 4, 2024
@Rozzii Rozzii added this to the BMO - v0.10 milestone Dec 4, 2024
@Rozzii Rozzii moved this from BMO WIP to Backlog in Metal3 - Roadmap Dec 4, 2024
@tuminoid
Copy link
Member

tuminoid commented Dec 5, 2024

Good point, maybe having it in Ironic is the most meaningful approach.

Ironic-client discussion separated to its own issue and relocation is underway: metal3-io/ironic-client#30

@Rozzii
Copy link
Member

Rozzii commented Dec 13, 2024

metal3-io/ironic-client#30 has been resolved, thanks @tuminoid . Now the only thing left to resolve this issue is to move the keepalived when the time is right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Status: Backlog
Development

No branches or pull requests

5 participants