lib/common.sh has passwordless sudo check

[tuminoid]

The passwordless sudo check in lib/common.sh is really idiotic. It requires you to have passwordless sudo in the first place, and secondly it needs to be configured the exact way that it then checks.

Instead, the script should just check that it is running as root, and should not run anything with sudo. Then it is up to user to run the top-level command with sudo, which allows it to have password or configure the passwordless in any way user wants.

In general, any lib should not execute code, but only define functions for scripts to execute.

[tuminoid]

/triage accepted
/cc @lentzi90 @kashifest

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[tuminoid]

/remove-lifecycle stale

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[Rozzii]

/remove-lifecycle stale

[metal3-io-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[Rozzii]

/remove-lifecycle stale

[tuminoid]

/lifecycle frozen