Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide CI coverage for optional mariadb support. #931

Open
Rozzii opened this issue Feb 3, 2022 · 20 comments
Open

Provide CI coverage for optional mariadb support. #931

Rozzii opened this issue Feb 3, 2022 · 20 comments
Assignees
@dtantsur @lentzi90 @kashifest
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@Rozzii
Copy link
Member

Rozzii commented Feb 3, 2022

Because of recent developments the SQlite has become the default database for ironic thus the MariaDB based setup is not being testes.

Based on community discussion and discussion on an other ticket #923, it has been decided that there is a need to provide integration tests in the CI for both SQlite and MariaDB based setups.

/kind feature
/help wanted
/cc @dtantsur
@metal3-io-bot metal3-io-bot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Feb 3, 2022
@Rozzii
Copy link
Member Author

Rozzii commented Feb 3, 2022

/assign @dtantsur @kashifest

@Rozzii Rozzii mentioned this issue Feb 3, 2022
Closed
@Rozzii
Copy link
Member Author

Rozzii commented Feb 3, 2022

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Feb 3, 2022
@kashifest
Copy link
Member

I am trying to understand the need of testing both, if sqlite is the default database, mariadb test isn't required that much unless someone is really using mariadb and against sqlite . We anyhow are planning to test an upgrade scenario where we have a mariadb based ironic deployment and we go on to deploy sqlite based ironic deployment .

@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2022
@Rozzii
Copy link
Member Author

Rozzii commented May 11, 2022

It is in my backlog, haven't had the time yet.
/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 11, 2022
@Rozzii
Copy link
Member Author

Rozzii commented May 11, 2022

/assign @Rozzii

@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2022
@Rozzii
Copy link
Member Author

Rozzii commented Aug 17, 2022

/remove-lifecycle stale
It is not a forgotten issue but somehow there is always more important things so if someone would like to implement this then please feel free to do so!
/help

@metal3-io-bot metal3-io-bot added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 17, 2022
@Rozzii Rozzii removed their assignment Aug 17, 2022
@Rozzii
Copy link
Member Author

Rozzii commented Oct 3, 2022

/assign @lentzi90

@Rozzii
Copy link
Member Author

Rozzii commented Oct 3, 2022

/remove-help

@metal3-io-bot metal3-io-bot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 3, 2022
@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 1, 2023
@lentzi90
Copy link
Member

lentzi90 commented Jan 2, 2023

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 2, 2023
@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2023
@furkatgofurov7
Copy link
Member

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 2, 2023
@lentzi90
Copy link
Member

lentzi90 commented Apr 3, 2023

/help cancel
I'm starting working on this now

@lentzi90 lentzi90 mentioned this issue Apr 3, 2023
Merged
@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2023
@Rozzii
Copy link
Member Author

Rozzii commented Jul 5, 2023

This slowly going forward but at this moment there is no job that is actively using mariaDB, but at some point there will be.

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2023
@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 3, 2023
@Rozzii
Copy link
Member Author

Rozzii commented Oct 3, 2023

/lifecycle-frozen
We had a situation where this would have been useful, but this has low priority atm.

@Rozzii
Copy link
Member Author

Rozzii commented Oct 3, 2023

/lifecycle frozen

@metal3-io-bot metal3-io-bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtantsur dtantsur

@lentzi90 lentzi90

@kashifest kashifest

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Metal3 - Roadmap
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dtantsur @lentzi90 @Rozzii @furkatgofurov7 @kashifest @metal3-io-bot