Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dead link in nodes-machines-and-hosts.md #488

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix dead link in nodes-machines-and-hosts.md #488

wants to merge 2 commits into from

Conversation

geekrypter
Copy link
Contributor

@geekrypter geekrypter commented Dec 9, 2024 •
edited by tuminoid
Loading

What is the change?
This change fixes a dead link in nodes-machines-and-hosts.md, and there is a minor text change.

Why the change?
Fixes: #441

@geekrypter
fix dead link
8fcce21 
Signed-off-by: Seetarama Raju Pericherla <[email protected]>
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 9, 2024
@metal3-io-bot
Copy link
Contributor

Hi @geekrypter. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 9, 2024
tuminoid
tuminoid reviewed Dec 10, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 10, 2024
@metal3-io-bot
Copy link
Contributor

@tuminoid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/ok-to-test
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 10, 2024
zhouhao3
zhouhao3 reviewed Dec 13, 2024
View reviewed changes
design/nodes-machines-and-hosts.md Outdated
@@ -57,7 +57,7 @@ such as draining the node for maintenance. The definition of Node is
owned by the Kubernetes core, and offers few opportunities to attach
custom data.

[Machine](https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html)
[Machine](https://cluster-api.sigs.k8s.io/developer/architecture/controllers/machine)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be https://cluster-api.sigs.k8s.io/developer/core/controllers/machine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this change in the latest commit

@geekrypter
change link
279d3d1 
Signed-off-by: Seetarama Raju Pericherla <[email protected]>
@zhouhao3
Copy link
Member

/lgtm

@metal3-io-bot
Copy link
Contributor

@zhouhao3: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tuminoid
Copy link
Member

Squash the commits, then its good to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouhao3 zhouhao3 zhouhao3 left review comments

@tuminoid tuminoid tuminoid left review comments

@elfosardo elfosardo Awaiting requested review from elfosardo

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix dead links at nodes-machines-and-hosts.md
4 participants
@geekrypter @metal3-io-bot @zhouhao3 @tuminoid