exchange/utils: check whether commit_unless_managed is available on current django installation #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrent django installation
|
|
||
| from django import VERSION | ||
| # see https://docs.djangoproject.com/en/1.9/internals/deprecation/#deprecation-removed-in-1-8 | ||
| if VERSION[2] < 7: |
There was a problem hiding this comment.
Thank you for the contribution. How about:
from distutils.version import StrictVersion
from django import get_version
if StrictVersion(get_version()) >= StrictVersion('1.6.0'):
with transaction.atomic():
....
https://docs.djangoproject.com/en/1.6/topics/db/transactions/#controlling-transactions-explicitly
On the other hand maybe we should not support < Django 1.6 at all.
There was a problem hiding this comment.
Hey, sorry for taking so long to see this!
I'll update this, can remove the version check if we should drop 1.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29