You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Discovered in testing of berkeley schema, specifically related to assert statements for test_workflow_execution_mapper in test_imports.py
The test has 4 files that pertain to two workflow executions but the test makes 4 workflow_execution_set records based on Import: true from the yaml file. These records will have an empty has_output. Technically the API still allows this but we shouldn't be doing this and if you fix #259 then the key wouldn't exist and then you'd get an error from the API about a missing required key. Low priority for now b/c It has not been a use case that we need to import annotations w/o upstream records but this could happen and we'd need to account for that. The code would need information about the has_output data object identifiers for the upstream workflow record and there is no logic to handle this right now.
The text was updated successfully, but these errors were encountered:
Discovered in testing of berkeley schema, specifically related to assert statements for test_workflow_execution_mapper in test_imports.py
The test has 4 files that pertain to two workflow executions but the test makes 4 workflow_execution_set records based on Import: true from the yaml file. These records will have an empty has_output. Technically the API still allows this but we shouldn't be doing this and if you fix #259 then the key wouldn't exist and then you'd get an error from the API about a missing required key. Low priority for now b/c It has not been a use case that we need to import annotations w/o upstream records but this could happen and we'd need to account for that. The code would need information about the has_output data object identifiers for the upstream workflow record and there is no logic to handle this right now.
The text was updated successfully, but these errors were encountered: