Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'data set' DOI to award DOI, multivalued, capture source/authority #224

Closed
Tracked by #161
mslarae13 opened this issue Aug 29, 2024 · 17 comments
Closed
Tracked by #161
Assignees

Comments

@mslarae13
Copy link
Contributor

mslarae13 commented Aug 29, 2024

Currently, the Context page in the submission portal has "DOI associated with the data in this study. This is required when data is already generated."

What we're really asking for here is the award DOI from the user facility.

We need this if data was generated by JGI or EMSL.
We can get it from the UP # that's provided, but would be easier if we could get people to add it themselves.

Screenshot 2024-08-29 at 9 59 53 AM

Screenshot 2024-08-29 at 9 52 34 AM

Example place to find award DOI: https://www.osti.gov/award-doi-service/biblio/10.46936/fics.proj.2017.49991/60006232
But, how does someone find that page??
@lamccue do you know?

@ssarrafan
Copy link

It's the last day of the sprint. I added @JamesTessmer to this ticket and will move it to the next sprint. @mslarae13 @JamesTessmer let me know if this is done or if it's not being worked on right now.

@JamesTessmer
Copy link

This is in progress, I should have an associated PR up next week for some review.

@JamesTessmer
Copy link

@mslarae13 I've got a branch and PR up for this now. It should be set up how you described in the pictures above. I saw the issue mentions changing the field to be multivalued. Did we want to make a change for that similar to the funding source change?

@JamesTessmer
Copy link

The associated PR for this issue is microbiomedata/nmdc-server#1380

@mslarae13
Copy link
Contributor Author

Discussed today. Adding some clarity

Dataset DOI should be completely re-named to award DOI for step 2- Submission Context. Step 2 does NOT collect any DATA information

Any DOI provided on step 2 is an award_doi for DOI category https://microbiomedata.github.io/nmdc-schema/doi_category/

IF you select NO, data has not been generated.

  • a award DOI box should appear under JGI & EMSL, if checked

If you select YES, data has been generated.

  • the award DOI box should appear.
  • you can add multiple, or leave this empty if you DO NOT select "doe user facility"
  • IF the DOE user facility box is checked, award DOI is required

Who is the provider?

  • TBD for YES, leave it blank
  • Use the user facility check box associated with the box that appear to fill in JGI or EMSL (or leave it blank & we can do this later)

@ssarrafan
Copy link

James is working on this now. Moving to next sprint.

@mslarae13
Copy link
Contributor Author

Decision today at infrastructure sync: will not merge until after berkeley-schema is in production, so after oct 15. There will be merge conflicts

@ssarrafan
Copy link

Based on last comment I'll move this to the next sprint @JamesTessmer @mslarae13

@ssarrafan
Copy link

Berkeley was rolled out. @JamesTessmer can this be closed by tomorrow?

@JamesTessmer
Copy link

All the work for this is done and the PR is ready and passes checks. I think I’m just waiting for a final “go ahead” to hit the merge button.

@ssarrafan
Copy link

All the work for this is done and the PR is ready and passes checks. I think I’m just waiting for a final “go ahead” to hit the merge button.

Final go ahead from @mslarae13? I'll move to the next sprint since she's out this week.

@mslarae13
Copy link
Contributor Author

Let's put this issue in next sprint, and maybe @pkalita-lbl and @JamesTessmer and I can sit down on a call and finalize it if needed or just get it merged in at the retreat

@JamesTessmer
Copy link

@mslarae13 I think Patrick tested it already and Mary approved the PR. I just tend to be overly cautious, but i think with your comment now its ok to merge in.

@mslarae13
Copy link
Contributor Author

Going to test in dev

  • did the data migrate?
  • is the text correct

@ssarrafan
Copy link

Moving to next sprint for testing
@mslarae13 @JamesTessmer

@mslarae13
Copy link
Contributor Author

@JamesTessmer I was probably supposed to test this out earlier, and forgot!

I just tested it, and it looks good.
One confirmation, when I check JGI , an award box appears.. when I check EMSL, an award DOI box appears.
These aren't tied to the check UF, right? it's just there's probably 2 award DOIs so here's 2 boxes?

@JamesTessmer
Copy link

Yeah, i think the assumption was that if you are checking both you would have 2 DOIs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ SubPort 1 - Done
Development

No branches or pull requests

3 participants