-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 'data set' DOI to award DOI, multivalued, capture source/authority #224
Comments
It's the last day of the sprint. I added @JamesTessmer to this ticket and will move it to the next sprint. @mslarae13 @JamesTessmer let me know if this is done or if it's not being worked on right now. |
This is in progress, I should have an associated PR up next week for some review. |
@mslarae13 I've got a branch and PR up for this now. It should be set up how you described in the pictures above. I saw the issue mentions changing the field to be multivalued. Did we want to make a change for that similar to the funding source change? |
The associated PR for this issue is microbiomedata/nmdc-server#1380 |
Discussed today. Adding some clarity Dataset DOI should be completely re-named to award DOI for step 2- Submission Context. Step 2 does NOT collect any DATA information Any DOI provided on step 2 is an award_doi for DOI category https://microbiomedata.github.io/nmdc-schema/doi_category/ IF you select NO, data has not been generated.
If you select YES, data has been generated.
Who is the provider?
|
James is working on this now. Moving to next sprint. |
Decision today at infrastructure sync: will not merge until after berkeley-schema is in production, so after oct 15. There will be merge conflicts |
Based on last comment I'll move this to the next sprint @JamesTessmer @mslarae13 |
Berkeley was rolled out. @JamesTessmer can this be closed by tomorrow? |
All the work for this is done and the PR is ready and passes checks. I think I’m just waiting for a final “go ahead” to hit the merge button. |
Final go ahead from @mslarae13? I'll move to the next sprint since she's out this week. |
Let's put this issue in next sprint, and maybe @pkalita-lbl and @JamesTessmer and I can sit down on a call and finalize it if needed or just get it merged in at the retreat |
@mslarae13 I think Patrick tested it already and Mary approved the PR. I just tend to be overly cautious, but i think with your comment now its ok to merge in. |
Going to test in dev
|
Moving to next sprint for testing |
@JamesTessmer I was probably supposed to test this out earlier, and forgot! I just tested it, and it looks good. |
Yeah, i think the assumption was that if you are checking both you would have 2 DOIs |
Currently, the Context page in the submission portal has "DOI associated with the data in this study. This is required when data is already generated."
What we're really asking for here is the award DOI from the user facility.
We need this if data was generated by JGI or EMSL.
We can get it from the UP # that's provided, but would be easier if we could get people to add it themselves.
Example place to find award DOI: https://www.osti.gov/award-doi-service/biblio/10.46936/fics.proj.2017.49991/60006232
But, how does someone find that page??
@lamccue do you know?
The text was updated successfully, but these errors were encountered: