Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all values listed in examples for a slot actually pass validation #227

Open
pkalita-lbl opened this issue Sep 24, 2024 · 8 comments
Assignees

Comments

@pkalita-lbl
Copy link
Collaborator

In microbiomedata/nmdc-field-notes#184, it was pointed out that there are a number of values listed as examples for some slots which do not conform to the validation rules of the slot itself. I manually confirmed that these slots have invalid examples:

  • local environmental context
  • depth, meters

I didn't check every slot so there very well may be more.

This task is to:

  1. repair or remove the current invalid examples
  2. develop a test in this repo that validates all of the example values and ensure that the build & release process fails if this test fails
@turbomam
Copy link
Member

turbomam commented Sep 24, 2024

It would be great if we could make this general enough to be used in totally separate repos

@turbomam
Copy link
Member

@pkalita-lbl
Copy link
Collaborator Author

This is in progress. A list of examples from submission-schema which do not pass validation has been prepared and set to Mark and Montana for review. Once that review is complete work will resume on either fixing the examples or changing slot definitions to make the existing examples validate.

@pkalita-lbl
Copy link
Collaborator Author

Still in progress. The review with Mark and Montana happened in this sprint and is mostly complete. Next sprint there will be two parallel tasks: I'll start fixing some of the examples we have a clear path forward on and also finish making decisions about the ones that are trickier.

@ssarrafan
Copy link

@pkalita-lbl still in progress?

@pkalita-lbl
Copy link
Collaborator Author

Yes. Moving.

@ssarrafan
Copy link

@pkalita-lbl is this one still active? backlog? next sprint?

@pkalita-lbl
Copy link
Collaborator Author

Honestly it's sort of blocked by some submission-schema build infrastructure issues. I should make a ticket for that work specifically. For now I'll just move it along, and I'll create an issue to better capture the immediate work in the new year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants