Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makefile cleanup: identify out-dated code; extract todos into issues #253

Open
turbomam opened this issue Oct 30, 2024 · 1 comment · May be fixed by #254
Open

makefile cleanup: identify out-dated code; extract todos into issues #253

turbomam opened this issue Oct 30, 2024 · 1 comment · May be fixed by #254
Assignees
@turbomam

Comments

@turbomam
Copy link
Member

remove some of these scripts?

oak-tree-to-pv-list = "nmdc_submission_schema.scripts.oak_tree_to_pv_list:main"
dh-json2linkml = 'nmdc_submission_schema.scripts.dh_json2linkml:update_json'
linkml-json2dh = 'nmdc_submission_schema.scripts.linkml_json2dh:extract_lists'
  • use fewer enums? is that really desirable or even possible?
  • use booleans for yes/no enumerations? what would the benefit be?
  • check for numbers that appear as strings in the schema (just examples? check for minimum value etc)
  • check if maximum value for pH has to be an int?
  • RDF/TTL generation is failing add rdf/ttl output to run-linkml-examples #13

old hints for alternate import sources in pyproject.toml:

  • /Users/MAM/Documents/gitrepos/sheets_and_friends
  • home/mark/gitrepos/sheets_and_friends
  • sheets-and-friends = { path = "/home/mark/gitrepos/sheets_and_friends", develop = true }
@turbomam turbomam self-assigned this Oct 30, 2024
turbomam added a commit that referenced this issue Oct 30, 2024
@turbomam
#253
4c71ad3
@turbomam turbomam linked a pull request Oct 30, 2024 that will close this issue
Draft
@turbomam turbomam linked a pull request Oct 30, 2024 that will close this issue
Makefile etc cleanup #254
Draft
@turbomam
Copy link
Member Author

removing these yq commands that had previously been commend out

#	yq -i '(.slots.[] | select(has("range") | not  ) | .range ) = "string"' $@
#	yq -i '(.classes.[].slot_usage.[] | select(has("range") | not  ) | .range ) = "string"' $@

#	yq -i '(.slots.[] | select(.name == "dna_dnase") | .range) = "boolean"' $@
#	yq -i '(.classes.[].slot_usage.[] | select(.name == "dna_dnase") | .range) = "boolean"' $@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turbomam turbomam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Makefile etc cleanup microbiomedata/submission-schema
1 participant
@turbomam