Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus RSocket Client not initialized when spring.main.lazy-initialization=true #83

Open
klopfdreh opened this issue Jul 1, 2024 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@klopfdreh
Copy link
Contributor

klopfdreh commented Jul 1, 2024

Currently we have an issue that the PrometheusRSocketClientAutoConfiguration does not initialize the PrometheusRSocketClient when the lazy-initialization is set to true.

I guess this is because PrometheusRSocketClient is not required anywhere due to autowiring.

Suggestion would be to add @Lazy(false) and test if this is working in this case.

@onobc / @jonatan-ivanov WDYT?

@jonatan-ivanov
Copy link
Member

Thanks for the issue.

Which version are you using? We've released 2.0.0-M1 which is using Boot 3.3, I'm not sure it will make any difference but there is a chance that PrometheusRSocketClientAutoConfiguration will create the client even if lazy-init is true.

@klopfdreh
Copy link
Contributor Author

Sorry - I didn’t mention it: Spring Boot 3.3 and Prometheus-RSocket-Client 2.0.0-M1

@jonatan-ivanov jonatan-ivanov added the bug Something isn't working label Jul 2, 2024
@jonatan-ivanov jonatan-ivanov added this to the 2.0.0-RC1 milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants