From 749f4c7d325574ac8358a3ec36238dd050d03907 Mon Sep 17 00:00:00 2001 From: Emil Marklund Date: Thu, 25 Oct 2018 00:32:01 +0200 Subject: [PATCH] Rename HTTP metrics to conform to best practices It seems like http_request_duration_seconds is the expected metric name for http request durations. This change is similar to https://github.com/microservices-demo/carts/commit/bd16e1e02aa005faf357902032c47bc66aed23df --- .../socks/shipping/middleware/HTTPMonitoringInterceptor.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/works/weave/socks/shipping/middleware/HTTPMonitoringInterceptor.java b/src/main/java/works/weave/socks/shipping/middleware/HTTPMonitoringInterceptor.java index fc6d0f8..6bde4a2 100644 --- a/src/main/java/works/weave/socks/shipping/middleware/HTTPMonitoringInterceptor.java +++ b/src/main/java/works/weave/socks/shipping/middleware/HTTPMonitoringInterceptor.java @@ -20,9 +20,9 @@ public class HTTPMonitoringInterceptor implements HandlerInterceptor { static final Histogram requestLatency = Histogram.build() - .name("request_duration_seconds") + .name("http_request_duration_seconds") .help("Request duration in seconds.") - .labelNames("service", "method", "route", "status_code") + .labelNames("service", "method", "path", "status_code") .register(); private static final String startTimeKey = "startTime";