Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for combinations of termination conditions in AGS #4325

Closed
Tracked by #4006
victordibia opened this issue Nov 22, 2024 · 0 comments · Fixed by #4369
Closed
Tracked by #4006

Add support for combinations of termination conditions in AGS #4325

victordibia opened this issue Nov 22, 2024 · 0 comments · Fixed by #4369
Assignees
Labels
proj-studio Related to AutoGen Studio.
Milestone

Comments

@victordibia
Copy link
Collaborator

victordibia commented Nov 22, 2024

Currently, you can only specify one termination condition in AGS.

"termination_condition": {
    "component_type": "termination",
    "termination_type": "MaxMessageTermination",
    "max_messages": 10
  }

However, AgentChat supports combinations of termination conditions

termination = termination = MaxMessageTermination(3) | TextMentionTermination("stop")

What

Extend AGS component factory and spec to support combinations of termination conditions

 "termination_condition": {
    "component_type": "termination",
    "termination_type": "CombinationTermination",
    "operator": "or",
    "conditions": [
      {
        "component_type": "termination",
        "termination_type": "TextMentionTermination",
        "text": "TERMINATE"
      },
      {
        "component_type": "termination",
        "termination_type": "MaxMessageTermination",
        "max_messages": 1
      }
    ]
  }
@victordibia victordibia added proj-studio Related to AutoGen Studio. and removed needs-triage labels Nov 22, 2024
@victordibia victordibia self-assigned this Nov 23, 2024
@victordibia victordibia added this to the 0.4.0 milestone Nov 23, 2024
victordibia added a commit that referenced this issue Nov 26, 2024
* fix import issue related to agentchat update #4245

* update uv lock file

* fix db auto_upgrade logic issue.

* im prove msg rendering issue

* Support termination condition combination. Closes #4325

* fix db instantiation bug

* update yarn.lock, closes #4260 #4262

* remove deps for now with vulnerabilities found by dependabot #4262

* update db tests

* add ability to load sessions from db ..

* format updates, add format checks to ags

* format check fixes

* linting and ruff check fixes

* make tests for ags non-parrallel to avoid db race conditions.

* format updates

* fix concurrency issue

* minor ui tweaks, move run start to websocket

* lint fixes

* update uv.lock

* Update python/packages/autogen-studio/autogenstudio/datamodel/types.py

Co-authored-by: Eric Zhu <[email protected]>

* Update python/packages/autogen-studio/autogenstudio/teammanager.py

Co-authored-by: Eric Zhu <[email protected]>

* reuse user proxy from agentchat

* ui tweaks

---------

Co-authored-by: Eric Zhu <[email protected]>
Co-authored-by: Hussein Mozannar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proj-studio Related to AutoGen Studio.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant