Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.NET] Rewire AgentBase.CallHandler to make use of HandleObject #4354

Open
LittleLittleCloud opened this issue Nov 25, 2024 · 0 comments · May be fixed by #4386
Open

[.NET] Rewire AgentBase.CallHandler to make use of HandleObject #4354

LittleLittleCloud opened this issue Nov 25, 2024 · 0 comments · May be fixed by #4386
Assignees
@LittleLittleCloud
Labels
dotnet issues related to AutoGen.Net

Comments

@LittleLittleCloud
Copy link
Collaborator

What feature would you like to be added?

Both AgentBase.CallHandler and HandleObject uses reflection to retrieve all implemented handler from the agent class. Rewire AgentBase.CallHandler to HandleObject help reduce duplicated code and increase test coverage.

Why is this needed?

Rewire AgentBase.CallHandler to make use of HandleObject
@MohMaz MohMaz added the dotnet issues related to AutoGen.Net label Nov 26, 2024
@LittleLittleCloud LittleLittleCloud linked a pull request Nov 26, 2024 that will close this issue
Open
3 tasks
LittleLittleCloud added a commit that referenced this issue Nov 26, 2024
@LittleLittleCloud
Merge branch 'main' into u/#4354
288a9cb
LittleLittleCloud added a commit that referenced this issue Nov 26, 2024
@LittleLittleCloud
Merge branch 'u/#4354' of https://github.com/microsoft/autogen into u/#…
d5a5fe3 
…4354
rysweet added a commit that referenced this issue Nov 27, 2024
@rysweet
Merge branch 'main' into u/#4354
f2ca194
MohMaz added a commit that referenced this issue Nov 27, 2024
@MohMaz
Merge branch 'main' into u/#4354
4e53aca
LittleLittleCloud added a commit that referenced this issue Nov 27, 2024
@LittleLittleCloud
Merge branch 'main' into u/#4354
2dc5246
rysweet added a commit that referenced this issue Nov 27, 2024
@rysweet
Merge branch 'main' into u/#4354
d1de9f6
LittleLittleCloud added a commit that referenced this issue Nov 27, 2024
@LittleLittleCloud
Merge branch 'main' into u/#4354
b3a6941
MohMaz added a commit that referenced this issue Nov 29, 2024
@MohMaz
Merge branch 'main' into u/#4354
010aa8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LittleLittleCloud LittleLittleCloud

Labels
dotnet issues related to AutoGen.Net
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.NET combine Handle and CallHandler microsoft/autogen
3 participants
@MohMaz @LittleLittleCloud @rysweet