Add warnings for deprecated azure oai config changes #4317
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
ekzhu
reviewed
Nov 22, 2024
| @@ -86,10 +86,29 @@ def _azure_openai_client_from_config(config: Mapping[str, Any]) -> AsyncAzureOpe | |||
| # Take a copy | |||
| copied_config = dict(config).copy() | |||
|
|
|||
| import warnings | |||
There was a problem hiding this comment.
In AzureOpenAIChatCompletionClient constructor model argument is still checked:
if "model" not in kwargs:
raise ValueError("model is required for OpenAIChatCompletionClient")There was a problem hiding this comment.
We also need to update the API documentation by changing the example in the doc string.
There was a problem hiding this comment.
We need to update usage of AzureOpenAIChatCompletionClient in the documentation to change model to azure_deployment. Can be do a separate PR after creating an issue for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #4316