Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BICEP] FinOps Toolkit - Custom resource naming #1105

Open
plaplainabf opened this issue Nov 7, 2024 · 0 comments
Open

[BICEP] FinOps Toolkit - Custom resource naming #1105

plaplainabf opened this issue Nov 7, 2024 · 0 comments
Labels
Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution Type: Feature 💎 Idea to improve the product

Comments

@plaplainabf
Copy link

⚠️ Problem

The bicep deployment doesn't allow the names of the resources to be set. This means that companies with naming standards can't deploy FinOps using bicep or the accept the resources won't adhere to their naming standards.

🛠️ Solution

Update the bicep code to include parameters for the names of the keyvault, data factory and storage accounts, this means that consumers can generate names using their own bicep naming modules and pass it through to the FinOps Toolkit deployment, providing a repeatable deployment.

ℹ️ Additional context

Looking at the FinOps Toolkit bicep code the main.bicep should be fairly easy to update for the data factory and storage account as there are two variables that are set.
Image

The keyvault name appears to be set within the keyvault.bicep so that would need a parameter defining and the main.bicep updating to pass through said parameter.

I believe parameters can have default values set, so these could be set to what the bicep deployment currently uses, that way it wouldn't break existing deployments.

This was originally posted in the wrong place;
Azure/bicep-registry-modules#3740 (comment)

🙋‍♀️ Ask for the community

We could use your help:

  1. Please vote this issue up (👍) to prioritize it.
@plaplainabf plaplainabf added the Needs: Triage 🔍 Untriaged issue needs to be reviewed label Nov 7, 2024
@arthurclares arthurclares added Type: Feature 💎 Idea to improve the product Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution and removed Needs: Triage 🔍 Untriaged issue needs to be reviewed labels Nov 7, 2024
@arthurclares arthurclares added this to the 2024-11 - November milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skill: Deployment Resource deployment automation via bicep or terraform Tool: FinOps hubs Data pipeline solution Type: Feature 💎 Idea to improve the product
Projects
None yet
Development

No branches or pull requests

3 participants